Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add false positive package to detect regressions in JSON marshalling #1734

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 19, 2024

Add a test package that reproduces the issue fixed in #717. This will help catching regressions caused by not using JSON numbers while decoding documents.

Fixes #732.

@jsoriano jsoriano requested a review from a team March 19, 2024 17:53
@jsoriano jsoriano self-assigned this Mar 19, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @jsoriano

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit 72677f0 into elastic:main Mar 20, 2024
3 checks passed
@jsoriano jsoriano deleted the test-package-json-encoding-numbers branch March 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit testing for pipeline test runner to cover json decoding and encoding
3 participants