Remove created agents in service deployer

[mrodm]

Part of #787

Currently, service deployers like custom_agent or kubernetes create new Elastic Agent instances and those agents are never removed (nor unenrolled) from Fleet once the tests are finished (system tests).

This PR removes these Elastic Agents created during tests from Fleet, so the stack state after running the tests is always without those Elastic Agents.

Moreover, to avoid errors like this if it is a long test execution:

 $ kubectl logs -n kube-system -f pod/elastic-agent-5ln2w
Error: unable to find enrollment token named "Default" in policy "Elastic-Agent (elastic-package)"
For help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/8.12/fleet-troubleshooting.html

Those new Elastic Agents are enrolled directly with the test Agent Policy created in each test.

[mrodm]

test integrations

[elasticmachine]

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9604

[mrodm]

test integrations

[elasticmachine]

Created or updated PR in integrations repository to test this version. Check elastic/integrations#9604

[elasticmachine]

💔 Build Failed

• Buildkite Build
• Commit: 096811f

Failed CI Steps

• :go: Integration test: benchmarks (independent agent)

History

• 💚 Build #2819 succeeded da7f8b8
• 💚 Build #2813 succeeded ddcc2f7
• 💔 Build #2812 failed 0b594e6
• 💔 Build #2809 failed 27bd2a4

cc @mrodm

[mrodm]

After testing with the integrations repository, it was noticed that kubernetes package could not enroll an Elastic Agent in one of the latest data streams that it has defined.

The error raised when testing in that data stream was:

 $ kubectl logs -n kube-system -f pod/elastic-agent-5ln2w
Error: unable to find enrollment token named "Default" in policy "Elastic-Agent (elastic-package)"
For help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/8.12/fleet-troubleshooting.html

To avoid this kind of errors, in those scenarios where new Elastic Agents are created, those agents will be enrolled using the new Agent Policy created in each test. Changes done in 096811f

Updated description accordingly.

[jsoriano]

Nit. Depending on the name of the agent may be fragile, we may forget to modify this if the set of names change.

[mrodm]

I could add a new field into svcInfo to set whether or not this service requires a new Agent (different from the stack).

Maybe something like this (adding Stack field) ?

elastic-package/internal/servicedeployer/info.go

Line 60 in 0647d80

Agent struct {

	// Agent related properties.
	Agent struct {
		// Host describes the machine which is running the agent.
		Host struct {
			// Name prefix for the host's name
			NamePrefix string
		}
		// Stack indicates whether or not this Agent is the one running/set in "elastic-package stack up"
		Stack bool
	}

WDYT @jsoriano ?

[mrodm]

Or maybe change it to be Independent

svcInfo.Agent.Independent (true or false)

[jsoriano]

Both options SGTM

[mrodm]

Perfect, I'll merge this PR as it is then, and I'll create a follow-up PR to remove those agent names with one of these options and run the tests with integrations again.

[mrodm]

Created PR #1776