Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore append before checking error #1782

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Apr 18, 2024

Restore appending results even if there is an error.

For instance, system tests could exit using result.WithError() method and that method could return both results and error:

return []TestResult{rc.TestResult}, err

@mrodm mrodm requested a review from a team April 18, 2024 08:38
@mrodm mrodm self-assigned this Apr 18, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrodm mrodm merged commit b2c2c7a into elastic:main Apr 18, 2024
3 checks passed
@mrodm mrodm deleted the restore_append_results branch April 18, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants