Add suffix to compose project names #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
May 20, 2024
| @@ -106,7 +106,7 @@ func (d *CustomAgentDeployer) SetUp(ctx context.Context, svcInfo ServiceInfo) (D | |||
|
|
|||
| service := dockerComposeDeployedService{ | |||
| ymlPaths: ymlPaths, | |||
| project: "elastic-package-service", | |||
| project: fmt.Sprintf("elastic-package-service-%s", svcInfo.Test.RunID), | |||
There was a problem hiding this comment.
I've updated this service deployer to keep consistency.
But it would not be needed, since this deployer is not used with independent Elastic Agents.
Would it be better to revert the change in this file?
This would make mandatory to change test configuration files for oracle package using the placeholders {{Hostname}} and {{Port}}.
There was a problem hiding this comment.
Well, it doesn't do any harm, right? Keep the change in case this continues to be used.
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
May 21, 2024
| @@ -106,7 +106,7 @@ func (d *CustomAgentDeployer) SetUp(ctx context.Context, svcInfo ServiceInfo) (D | |||
|
|
|||
| service := dockerComposeDeployedService{ | |||
| ymlPaths: ymlPaths, | |||
| project: "elastic-package-service", | |||
| project: fmt.Sprintf("elastic-package-service-%s", svcInfo.Test.RunID), | |||
There was a problem hiding this comment.
Well, it doesn't do any harm, right? Keep the change in case this continues to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1838
Add suffix (run ID string) to compose project created by terraform and custom agent service deployers.