Fixed deserialization of datetime.date fields #1914
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
date-deserialization-fix
branch
2 times, most recently
from
64257a5 to
f512f1e
Compare
miguelgrinberg
force-pushed
the
date-deserialization-fix
branch
from
f512f1e to
6444c80
Compare
pquentin
approved these changes
Sep 13, 2024
| assert dt == f._deserialize(dt.isoformat()) | ||
|
|
||
| d = date.today() | ||
| assert datetime.combine(d, time()) == f._deserialize(d.isoformat()) |
There was a problem hiding this comment.
It took me a while to understand that this wasn't time.time() but converting to a datetime at midnight.
There was a problem hiding this comment.
I had a passing thought that datetime.time() might be confused with time.time() as well. Maybe I should namespace it here.
miguelgrinberg
added a commit
that referenced
this pull request
Sep 13, 2024
miguelgrinberg
added a commit
to miguelgrinberg/elasticsearch-dsl-py
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1913