Skip to content

use File type for javaHome and bump build-tools version #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakelandis merged 1 commit into from
Aug 23, 2019
Merged

use File type for javaHome and bump build-tools version #1338

jakelandis merged 1 commit into from
Aug 23, 2019

Conversation

@jakelandis
Copy link
Contributor

@jakelandis jakelandis commented Aug 23, 2019

As of elastic/elasticsearch#45677 build tools
now uses a function that requires javaHome to be a File type.

This commit updates the JavaHome property to be a File type. This
commit also bumps the latest supported version of build-tools (8.0.0-SNAPSHOT
is not supported yet).

@jakelandis jakelandis requested a review from jbaiera August 23, 2019 18:50
jakelandis
jakelandis commented Aug 23, 2019
View reviewed changes
buildSrc/build.gradle

// Provided/Optional Dependencies
compile 'org.springframework.build.gradle:propdeps-plugin:0.0.7'
implementation 'org.apache.logging.log4j:log4j-core:2.11.1'
Copy link
Contributor Author

@jakelandis jakelandis Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is necessary, else the build will fail. (it is also present in 7.x)

@jakelandis jakelandis requested a review from mark-vieira August 23, 2019 18:53
@jakelandis
Copy link
Contributor Author

jakelandis commented Aug 23, 2019 •
edited
Loading

This is what the failure this fixes looks like

FAILURE: Build failed with an exception.

* What went wrong:
Failed to notify build listener.
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)
> No signature of method: static org.gradle.internal.jvm.Jvm.forHome() is applicable for argument types: (java.lang.String) values: [/Users/jakelandis/workspace/java/jdk-8-update-211/Contents/Home]
  Possible solutions: forHome(java.io.File)

jbaiera
jbaiera approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buildSrc/esh-version.properties
elasticsearch = 8.0.0
lucene = 8.1.0-snapshot-e460356abe
build-tools = 7.1.1
build-tools = 7.4.0-SNAPSHOT
Copy link
Member

@jbaiera jbaiera Aug 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping this up. We're pretty close to being able to run against the master build tools here soon enough.

@jakelandis jakelandis merged commit 8d4bdb8 into elastic:master Aug 23, 2019
@jakelandis jakelandis deleted the javaHome_file_type branch August 23, 2019 18:58
jakelandis added a commit that referenced this pull request Aug 23, 2019
@jakelandis
use File type for javaHome and bump build-tools version (#1338)
c9714d3 
As of elastic/elasticsearch#45677 build tools
now uses a function that requires JavaHome to be a File type.

This commit updates the JavaHome property to be a File type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaiera jbaiera jbaiera approved these changes

@mark-vieira mark-vieira Awaiting requested review from mark-vieira

Assignees

No one assigned

Labels

:Build v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakelandis @jbaiera