Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NoLivingConnectionsError #1045

Merged
merged 5 commits into from
Feb 3, 2020
Merged

Conversation

gomesalexandre
Copy link
Contributor

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@delvedor
Copy link
Member

delvedor commented Jan 8, 2020

jenkins run the tests please

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the bugfix label Jan 8, 2020
@gomesalexandre
Copy link
Contributor Author

Rebased master

@delvedor
Copy link
Member

Sorry, forgot to mention, can you sign the CLA? Thanks!

@gomesalexandre
Copy link
Contributor Author

Sorry, forgot to mention, can you sign the CLA? Thanks!

I already did!

@delvedor
Copy link
Member

@gomesalexandre, unfortunately, the CLA checkers still fails, are you sure you have used the same email of you Git configuration?

@gomesalexandre
Copy link
Contributor Author

@gomesalexandre, unfortunately, the CLA checkers still fails, are you sure you have used the same email of you Git configuration?

It might be, signed it again !

@gomesalexandre
Copy link
Contributor Author

travis re-test?

@delvedor
Copy link
Member

jenkins run the tests please

@delvedor delvedor merged commit 7945b68 into elastic:master Feb 3, 2020
delvedor added a commit that referenced this pull request Feb 4, 2020
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
delvedor added a commit that referenced this pull request Feb 4, 2020
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
delvedor added a commit that referenced this pull request Feb 4, 2020
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
delvedor added a commit that referenced this pull request Feb 4, 2020
Co-authored-by: Tomas Della Vedova <delvedor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants