Change TransportRequestOptions.ignore to number[] #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying JavaScript handles arrays of any length. The current type of TransportRequestOptions.ignore, which is [number], only allows arrays with length==1, which looks like a mistake, and prevents the ignore API from being usable when we want to ignore multiple error statuses (which I do).
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins run the tests please |
Done. |
delvedor
pushed a commit
that referenced
this pull request
Jan 15, 2020
delvedor
pushed a commit
that referenced
this pull request
Jan 15, 2020
delvedor
pushed a commit
that referenced
this pull request
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying JavaScript handles arrays of any length. The current type of TransportRequestOptions.ignore, which is [number], only allows arrays with length==1, which looks like a mistake, and prevents the ignore API from being usable when we want to ignore multiple error statuses (which I do).