Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body and querystring to RequestOptions #957

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Add body and querystring to RequestOptions #957

merged 1 commit into from
Sep 11, 2019

Conversation

villasv
Copy link
Contributor

@villasv villasv commented Sep 4, 2019

Fixes #951 adding the missing fields.

@villasv
Copy link
Contributor Author

villasv commented Sep 5, 2019

Looks like a flaky build. Would the repo admins mind a re-trigger?

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor
Copy link
Member

jenkins run the tests please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection.request params expected RequestOptions without querystring
2 participants