Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure mypy to ignore missing imports during build #2641

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

miguelgrinberg
Copy link
Contributor

The build script runs mypy without the ignore-missing-imports flag. This used to be fine, but with the introduction of pyarrow the flag is needed because this library does not have type hints. The mypy build triggered from nox works fine because it already has this option enabled.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. We need to use the configuration file more.

@pquentin pquentin merged commit 47dcd2b into elastic:main Aug 19, 2024
11 checks passed
@miguelgrinberg miguelgrinberg deleted the build-ignore-missing-imports branch August 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants