Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single bucket aggregates have nested aggregates #1243

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Single bucket aggregates have nested aggregates #1243

merged 2 commits into from
Jan 12, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Jan 10, 2022

Fixes #1221

SingleBucketAggregateBase accepts nested aggregations.

This PR also fixes parent and children aggregate that are single bucket aggregates and adds the missing unmapped_sampler aggregate.

Validation shows no new error related to the change:

% make validate api=search type=response stack-version=8.0.0-SNAPSHOT
- Validating endpoints
⚠ It looks like search response has some errors, take a look at the workbench.
/Users/sylvain/dev/elastic/src/clients/clients-flight-recorder/scripts/types-validator/workbench

scripts/types-validator/workbench/4fc631504dd7228aa9688c037933c48c.test-d.ts:16:6
Property '_id' is missing in type '{ _index: string; _score: number; }' but required in type 'SearchHit<unknown>'.

✖ 1560 out of 1561 test response cases are passing.

@swallez swallez requested review from delvedor and philkra January 10, 2022 16:41
@swallez swallez self-assigned this Jan 10, 2022
@swallez swallez mentioned this pull request Jan 10, 2022
Closed
delvedor
delvedor approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swallez swallez merged commit 9586b3a into main Jan 12, 2022
@swallez swallez deleted the nested-single-bucket-aggs branch January 12, 2022 10:53
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@swallez @github-actions
Single bucket aggregates have nested aggregates (#1243)
eaa6ba0
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@swallez @github-actions
Single bucket aggregates have nested aggregates (#1243)
7669be9
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
Merged
swallez added a commit that referenced this pull request Jan 12, 2022
@github-actions @swallez
Single bucket aggregates have nested aggregates (#1243) (#1248)
063e97d 
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Jan 12, 2022
@github-actions @swallez
Single bucket aggregates have nested aggregates (#1243) (#1249)
a09a49b 
Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
@joelbolt35 joelbolt35 mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delvedor delvedor delvedor approved these changes

@philkra philkra Awaiting requested review from philkra

Assignees

@swallez swallez

Labels
backport 7.17 backport 8.0 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NestedAggregate extends wrong base
2 participants
@swallez @delvedor