Skip to content

Commit

Permalink
Rename dangling index APIs (#58266)
Browse files Browse the repository at this point in the history
The dangling_indices.import API name could cause issues in the client
libs because import is a reserved word in many languages. Rename the
API to avoid this, and rename the other APIs for consistency.

Related to #48366.
  • Loading branch information
pugnascotia authored Jun 18, 2020
1 parent fa10cf5 commit 1f6c953
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -813,9 +813,9 @@ public void testApiNamingConventions() throws Exception {
"cluster.stats",
"cluster.post_voting_config_exclusions",
"cluster.delete_voting_config_exclusions",
"dangling_indices.delete",
"dangling_indices.import",
"dangling_indices.list",
"dangling_indices.delete_dangling_index",
"dangling_indices.import_dangling_index",
"dangling_indices.list_dangling_indices",
"indices.shard_stores",
"indices.upgrade",
"indices.recovery",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"dangling_indices.delete": {
"dangling_indices.delete_dangling_index": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-gateway-dangling-indices.html",
"description": "Deletes the specified dangling index"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"dangling_indices.import": {
"dangling_indices.import_dangling_index": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-gateway-dangling-indices.html",
"description": "Imports the specified dangling index"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"dangling_indices.list": {
"dangling_indices.list_dangling_indices": {
"documentation": {
"url": "https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-gateway-dangling-indices.html",
"description": "Returns all dangling indices."
Expand Down

0 comments on commit 1f6c953

Please sign in to comment.