Skip to content

Commit 5e668ad

Browse files
committed
Add additional logging for #43034
It's unclear why sometimes the shard is not flushed on closing
1 parent 119faee commit 5e668ad

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

server/src/main/java/org/elasticsearch/index/IndexService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,8 @@ private void closeShard(String reason, ShardId sId, IndexShard indexShard, Store
471471
try {
472472
// only flush we are we closed (closed index or shutdown) and if we are not deleted
473473
final boolean flushEngine = deleted.get() == false && closed.get();
474+
logger.trace("[{}] closing shard (flushEngine: {}, deleted: {}, closed: {})", shardId, flushEngine, deleted.get(),
475+
closed.get());
474476
indexShard.close(reason, flushEngine);
475477
} catch (Exception e) {
476478
logger.debug(() -> new ParameterizedMessage("[{}] failed to close index shard", shardId), e);

server/src/main/java/org/elasticsearch/index/engine/Engine.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1716,6 +1716,8 @@ public void flushAndClose() throws IOException {
17161716
close(); // double close is not a problem
17171717
}
17181718
}
1719+
} else {
1720+
logger.trace("skipping flushAndClose as already closed");
17191721
}
17201722
awaitPendingClose();
17211723
}

0 commit comments

Comments
 (0)