From 724b244d7a72e18b9bd184f4bcb9cfc1f4967a16 Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Tue, 10 Nov 2020 13:21:09 -0500 Subject: [PATCH] Fix buggy test In #64374 I broke a test that serializes `SearchRequest` with a random version. I'm unsure how we didn't catch this in the PR tests but computers are tricky. This fixes the test by removing runtime mappings for versions that don't support it. --- .../org/elasticsearch/action/search/SearchRequestTests.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/src/test/java/org/elasticsearch/action/search/SearchRequestTests.java b/server/src/test/java/org/elasticsearch/action/search/SearchRequestTests.java index 4d8c161176f62..caa71c030b1e4 100644 --- a/server/src/test/java/org/elasticsearch/action/search/SearchRequestTests.java +++ b/server/src/test/java/org/elasticsearch/action/search/SearchRequestTests.java @@ -81,6 +81,10 @@ public void testSerialization() throws Exception { public void testRandomVersionSerialization() throws IOException { SearchRequest searchRequest = createSearchRequest(); Version version = VersionUtils.randomVersion(random()); + if (version.before(Version.V_8_0_0) && searchRequest.source() != null) { + // Versions before 8.0.0 don't support runtime mappings + searchRequest.source().runtimeMappings(emptyMap()); + } SearchRequest deserializedRequest = copyWriteable(searchRequest, namedWriteableRegistry, SearchRequest::new, version); assertEquals(searchRequest.isCcsMinimizeRoundtrips(), deserializedRequest.isCcsMinimizeRoundtrips()); assertEquals(searchRequest.getLocalClusterAlias(), deserializedRequest.getLocalClusterAlias());