Skip to content

Commit

Permalink
Mute multiple tests on Windows (7.3) (#44677)
Browse files Browse the repository at this point in the history
* Mute failing test

tracked in #44552

* mute EvilSecurityTests

tracking in #44558

* Mute failing ForecastIT  test on windows

Tracking in #44609

* mute BasicRenormalizationIT.testDefaultRenormalization

tracked in #44613

* mute x-pack internal cluster test windows

tracking #44610

* Mute failure unconfigured node name

* fix mute testDefaultRenormalization

* Increase busyWait timeout windows is slow

* Mute JvmErgonomicsTests on windows

Tracking #44669

* mute SharedClusterSnapshotRestoreIT testParallelRestoreOperationsFromSingleSnapshot

Tracking #44671

* Mute NodeTests on Windows

Tracking #44256
  • Loading branch information
alpar-t authored Jul 22, 2019
1 parent 2c6debc commit 9cb2ab3
Show file tree
Hide file tree
Showing 10 changed files with 32 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

package org.elasticsearch.tools.launchers;

import org.junit.Before;

import java.io.IOException;
import java.util.Arrays;
import java.util.Collections;
Expand All @@ -41,6 +43,13 @@

public class JvmErgonomicsTests extends LaunchersTestCase {

@Before
public void setUp() {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44669",
System.getProperty("os.name").contains("Win")
);
}

public void testExtractValidHeapSizeUsingXmx() throws InterruptedException, IOException {
assertThat(
JvmErgonomics.extractHeapSize(JvmErgonomics.finalJvmOptions(Collections.singletonList("-Xmx2g"))),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ public class GeoIpProcessorFactoryTests extends ESTestCase {

@BeforeClass
public static void loadDatabaseReaders() throws IOException {
// there are still problems on windows
assumeFalse("https://github.com/elastic/elasticsearch/issues/44552", Constants.WINDOWS);

// Skip setup because Windows cannot cleanup these files properly. The reason is that they are using
// a MappedByteBuffer which will keep the file mappings active until it is garbage-collected. As a consequence,
// the corresponding file appears to be still in use and Windows cannot delete it.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ public void testEnvironmentPaths() throws Exception {
}

public void testDuplicateDataPaths() throws IOException {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44558", Constants.WINDOWS);
final Path path = createTempDir();
final Path home = path.resolve("home");
final Path data = path.resolve("data");
Expand Down
4 changes: 4 additions & 0 deletions qa/unconfigured-node-name/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.elasticsearch.gradle.OS

/*
* Licensed to Elasticsearch under one or more contributor
* license agreements. See the NOTICE file distributed with
Expand Down Expand Up @@ -28,4 +30,6 @@ testClusters.integTest {
integTest.runner {
nonInputProperties.systemProperty 'tests.logfile',
"${ -> testClusters.integTest.singleNode().getServerLog() }"
// https://github.com/elastic/elasticsearch/issues/44656
onlyIf { OS.WINDOWS.equals(OS.current()) == false }
}
2 changes: 2 additions & 0 deletions server/src/test/java/org/elasticsearch/node/NodeTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.elasticsearch.node;

import org.apache.lucene.util.Constants;
import org.apache.lucene.util.LuceneTestCase;
import org.elasticsearch.bootstrap.BootstrapCheck;
import org.elasticsearch.bootstrap.BootstrapContext;
Expand Down Expand Up @@ -149,6 +150,7 @@ private static Settings.Builder baseSettings() {
}

public void testCloseOnOutstandingTask() throws Exception {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44256", Constants.WINDOWS);
Node node = new MockNode(baseSettings().build(), basePlugins());
node.start();
ThreadPool threadpool = node.injector().getInstance(ThreadPool.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ protected void nodeOperation(AllocatedPersistentTask task, TestParams params, Pe
assertTrue(awaitBusy(() -> testTask.isCancelled() ||
testTask.getOperation() != null ||
clusterService.lifecycleState() != Lifecycle.State.STARTED, // speedup finishing on closed nodes
30, TimeUnit.SECONDS)); // This can take a while during large cluster restart
45, TimeUnit.SECONDS)); // This can take a while during large cluster restart
if (clusterService.lifecycleState() != Lifecycle.State.STARTED) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

package org.elasticsearch.snapshots;

import org.apache.lucene.util.Constants;
import org.apache.lucene.util.SetOnce;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.ExceptionsHelper;
Expand Down Expand Up @@ -3394,6 +3395,7 @@ public void testSnapshotSucceedsAfterSnapshotFailure() throws Exception {
}

public void testSnapshotStatusOnFailedIndex() throws Exception {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44671", Constants.WINDOWS);
logger.info("--> creating repository");
final Path repoPath = randomRepoPath();
final Client client = client();
Expand Down
6 changes: 6 additions & 0 deletions x-pack/plugin/ccr/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import org.elasticsearch.gradle.OS

evaluationDependsOn(xpackModule('core'))

apply plugin: 'elasticsearch.esplugin'
Expand All @@ -22,6 +24,8 @@ task internalClusterTestNoSecurityManager(type: Test) {
include noSecurityManagerITClasses
systemProperty 'es.set.netty.runtime.available.processors', 'false'
systemProperty 'tests.security.manager', 'false'
// Disable tests on windows https://github.com/elastic/elasticsearch/issues/44610
onlyIf { OS.WINDOWS.equals(OS.current()) == false }
}

// Instead we create a separate task to run the
Expand All @@ -34,6 +38,8 @@ task internalClusterTest(type: Test) {
include '**/*IT.class'
exclude noSecurityManagerITClasses
systemProperty 'es.set.netty.runtime.available.processors', 'false'
// Disable tests on windows https://github.com/elastic/elasticsearch/issues/44610
onlyIf { OS.WINDOWS.equals(OS.current()) == false }
}

check.dependsOn internalClusterTest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
package org.elasticsearch.xpack.ml.integration;

import org.apache.lucene.util.Constants;
import org.elasticsearch.common.unit.TimeValue;
import org.elasticsearch.xpack.core.ml.action.GetRecordsAction;
import org.elasticsearch.xpack.core.ml.job.config.AnalysisConfig;
Expand Down Expand Up @@ -32,6 +33,7 @@ public void tearDownData() {
}

public void testDefaultRenormalization() throws Exception {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44613", Constants.WINDOWS);
String jobId = "basic-renormalization-it-test-default-renormalization-job";
createAndRunJob(jobId, null);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/
package org.elasticsearch.xpack.ml.integration;

import org.apache.lucene.util.Constants;
import org.elasticsearch.ElasticsearchException;
import org.elasticsearch.ElasticsearchStatusException;
import org.elasticsearch.action.support.master.AcknowledgedResponse;
Expand Down Expand Up @@ -211,6 +212,7 @@ public void testMemoryStatus() throws Exception {
}

public void testOverflowToDisk() throws Exception {
assumeFalse("https://github.com/elastic/elasticsearch/issues/44609", Constants.WINDOWS);
Detector.Builder detector = new Detector.Builder("mean", "value");
detector.setByFieldName("clientIP");

Expand Down

0 comments on commit 9cb2ab3

Please sign in to comment.