Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cache when profiling requests #33298

Closed
iverase opened this issue Aug 31, 2018 · 1 comment · Fixed by #48195
Closed

Disable cache when profiling requests #33298

iverase opened this issue Aug 31, 2018 · 1 comment · Fixed by #48195
Labels
>bug :Search/Search Search-related issues that do not fall into other categories

Comments

@iverase
Copy link
Contributor

iverase commented Aug 31, 2018

Today, profiled search requests can use the cache, which can lead to very different profiling times if the same query is profiled twice or you can have a slow took time but a fast profile result . Profiling should never really use the cache at all because of the nature of profiling.

Related with #29024 although what is here proposed is that the profile works as if the query was never cached. Therefore it can lead to fast took time but slow profile results.
@iverase iverase added >bug :Search/Search Search-related issues that do not fall into other categories labels Aug 31, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

jimczi added a commit to jimczi/elasticsearch that referenced this issue Oct 17, 2019
@jimczi
Disable caching when queries are profiled
364c110 
This change disables the query and request cache when
profile is set to true in the request. This means that profiled queries
will not check caches to execute the query and the result will never be
added in the cache either.

Closes elastic#33298
@jimczi jimczi mentioned this issue Oct 17, 2019
Merged
jimczi added a commit that referenced this issue Nov 20, 2019
@jimczi
Disable caching when queries are profiled (#48195)
15023ba 
This change disables the query and request cache when
profile is set to true in the request. This means that profiled queries
will not check caches to execute the query and the result will never be
added in the cache either.

Closes #33298
jimczi added a commit that referenced this issue Nov 20, 2019
@jimczi
Disable caching when queries are profiled (#48195)
81548df 
This change disables the query and request cache when
profile is set to true in the request. This means that profiled queries
will not check caches to execute the query and the result will never be
added in the cache either.

Closes #33298
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable caching when queries are profiled jimczi/elasticsearch
2 participants
@elasticmachine @iverase