Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testRestoreIncreasesPrimaryTerms fails on 6.x #38223

Closed
dnhatn opened this issue Feb 1, 2019 · 2 comments
Closed

testRestoreIncreasesPrimaryTerms fails on 6.x #38223

dnhatn opened this issue Feb 1, 2019 · 2 comments
Assignees
@tlrx
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Feb 1, 2019 •
edited
Loading

I can reproduce this locally with the following command.

./gradlew :server:integTest \
  -Dtests.seed=8E0D4395046AC9E0 \
  -Dtests.class=org.elasticsearch.snapshots.SharedClusterSnapshotRestoreIT \
  -Dtests.method="testRestoreIncreasesPrimaryTerms" \
  -Dtests.security.manager=true \
  -Dtests.locale=el \
  -Dtests.timezone=Pacific/Tahiti \
  -Dcompiler.java=11 \
  -Druntime.java=8

AILURE 2.48s | SharedClusterSnapshotRestoreIT.testRestoreIncreasesPrimaryTerms <<< FAILURES!
   > Throwable #1: java.lang.AssertionError:
   > Expected: <4L>
   >      but: was <5L>
   >    at __randomizedtesting.SeedInfo.seed([8E0D4395046AC9E0:46EF6D1E229D6B72]:0)
   >    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   >    at org.elasticsearch.snapshots.SharedClusterSnapshotRestoreIT.testRestoreIncreasesPrimaryTerms(SharedClusterSnapshotRestoreIT.java:3746)
   >    at java.lang.Thread.run(Thread.java:748)

CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1325/console

Relates #38177
@dnhatn dnhatn added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Feb 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

dnhatn added a commit to dnhatn/elasticsearch that referenced this issue Feb 1, 2019
@dnhatn
AwaitsFix testRestoreIncreasesPrimaryTerms
4b1f25f 
Tracked at elastic#38223
@dnhatn dnhatn mentioned this issue Feb 1, 2019
Merged
dnhatn added a commit that referenced this issue Feb 1, 2019
@dnhatn
AwaitsFix testRestoreIncreasesPrimaryTerms (#38224)
c01d98b 
Tracked at #38223
tlrx added a commit to tlrx/elasticsearch that referenced this issue Feb 4, 2019
@tlrx
Fix testRestoreIncreasesPrimaryTerms on 6.x
3720979 
In 6.x the open index request does not wait for shards to be active and
returns immediately. In this specific test, we want to capture the
values of the primary terms before the snapshot and restore and if it
does not wait for shard to be active the captured values might not be
up to date.

Closes elastic#38223
@tlrx tlrx mentioned this issue Feb 4, 2019
Merged
tlrx added a commit that referenced this issue Feb 4, 2019
@tlrx
Fix testRestoreIncreasesPrimaryTerms on 6.x (#38314)
956c5cd 
In 6.x the open index request does not wait for shards to be active and
returns immediately. In this specific test, we want to capture the
values of the primary terms before the snapshot and restore and if it
does not wait for shard to be active the captured values might not be
up to date.

Closes #38223
@tlrx
Copy link
Member

tlrx commented Feb 5, 2019

Closed by #38314

@tlrx tlrx closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlrx tlrx

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tlrx @dnhatn @elasticmachine