Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Move metric counting inside the PlanExecutor #38258

Closed
costin opened this issue Feb 2, 2019 · 1 comment
Closed

SQL: Move metric counting inside the PlanExecutor #38258

costin opened this issue Feb 2, 2019 · 1 comment
Labels
:Analytics/SQL SQL querying >non-issue v6.7.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Feb 2, 2019

Since the plan executor can be called internally, it makes sense to move the metrics away from the transport layer inside the plan executor. On the upside this also keeps the code in one place and increments the metrics even in unit testing.

related to #35118
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

costin added a commit to costin/elasticsearch that referenced this issue Feb 2, 2019
@costin
SQL: Move metrics tracking inside PlanExecutor
5bf99a1 
Move metrics in one place, from the transport layer inside the
PlanExecutor

Close elastic#38258
@costin costin mentioned this issue Feb 2, 2019
Merged
costin added a commit that referenced this issue Feb 3, 2019
@costin
SQL: Move metrics tracking inside PlanExecutor (#38259)
a088155 
Move metrics in one place, from the transport layer inside the
PlanExecutor
Remove unused class

Close #38258
costin added a commit to costin/elasticsearch that referenced this issue Feb 3, 2019
@costin
SQL: Move metrics tracking inside PlanExecutor (elastic#38259)
552c4f7 
Move metrics in one place, from the transport layer inside the
PlanExecutor
Remove unused class

Close elastic#38258

(cherry picked from commit a088155)
@costin costin mentioned this issue Feb 3, 2019
Merged
costin added a commit that referenced this issue Feb 4, 2019
@costin
SQL: Move metrics tracking inside PlanExecutor (#38259) (#38288)
5900096 
Move metrics in one place, from the transport layer inside the
PlanExecutor
Remove unused class

Close #38258

(cherry picked from commit a088155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >non-issue v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @colings86 @elasticmachine