Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Enhance check for text fields without underlying keyword #38501

Closed
matriv opened this issue Feb 6, 2019 · 1 comment · Fixed by #39427
Closed

SQL: Enhance check for text fields without underlying keyword #38501

matriv opened this issue Feb 6, 2019 · 1 comment · Fixed by #39427
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >enhancement

Comments

@matriv
Copy link
Contributor

matriv commented Feb 6, 2019

For functions/operators than cannot operate on text fields move the validation that's currently happening in places like QueryTranslator to resolveType().
Also avoid throwing an Exception from exactAttribute()->TextEsField.getExactField() method call, but instead introduce new method that has a proper return type that can be used for the validation.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@matriv matriv mentioned this issue Feb 6, 2019
Merged
@matriv matriv self-assigned this Feb 13, 2019
matriv added a commit to matriv/elasticsearch that referenced this issue Feb 27, 2019
@matriv
SQL: Enhance checks for inexact fields
4456106 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Fixes: elastic#38501
@matriv matriv mentioned this issue Feb 27, 2019
Merged
matriv added a commit that referenced this issue Feb 28, 2019
@matriv
SQL: Enhance checks for inexact fields (#39427)
10ab391 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Closes: #38501
Fixes: #35203
matriv added a commit that referenced this issue Mar 1, 2019
@matriv
SQL: Enhance checks for inexact fields (#39427)
9fb2f67 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Closes: #38501
Fixes: #35203
matriv added a commit that referenced this issue Mar 1, 2019
@matriv
SQL: Enhance checks for inexact fields (#39427)
2c39bb3 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Closes: #38501
Fixes: #35203
matriv added a commit that referenced this issue Mar 1, 2019
@matriv
SQL: Enhance checks for inexact fields (#39427)
bfc6e22 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Closes: #38501
Fixes: #35203
matriv added a commit that referenced this issue Mar 1, 2019
@matriv
SQL: Enhance checks for inexact fields (#39427)
9c60367 
For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Closes: #38501
Fixes: #35203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Enhance checks for inexact fields matriv/elasticsearch
2 participants
@matriv @elasticmachine