Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md doesn't explain when :run is done #57097

Closed
tvernum opened this issue May 25, 2020 · 2 comments
Closed

CONTRIBUTING.md doesn't explain when :run is done #57097

tvernum opened this issue May 25, 2020 · 2 comments
Assignees
@nik9000
Labels
:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team

Comments

@tvernum
Copy link
Contributor

tvernum commented May 25, 2020

See #47678 (comment)

The contributing guide says:

You can run Elasticsearch without building all the artifacts with:

./gradlew :run

You can access Elasticsearch with:

curl -u elastic:password localhost:9200

But, since :run never terminates, a new contributor may not realise that this task will eventually hit a point when ES is now running and is ready for input (the curl step).

It would be good to update that doc with a little more explanation so that it's clear what to expect and how to proceed.
@tvernum tvernum added >docs General docs changes :Delivery/Build Build or test infrastructure needs:triage Requires assignment of a team area label labels May 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 25, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 25, 2020
@nik9000 nik9000 removed the needs:triage Requires assignment of a team area label label May 29, 2020
@nik9000 nik9000 self-assigned this May 29, 2020
nik9000 added a commit that referenced this issue May 29, 2020
@nik9000
Expain when gradle run is ready
b15a304 
It isn't obvious.

Closes #57097
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:Delivery/Build Build or test infrastructure >docs General docs changes Team:Delivery Meta label for Delivery team Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nik9000 @tvernum @mark-vieira @elasticmachine