Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evaluate_data_frame REST test can fail from unexpected warnings #72046

Closed
jtibshirani opened this issue Apr 21, 2021 · 2 comments · Fixed by #72069
Closed

evaluate_data_frame REST test can fail from unexpected warnings #72046

jtibshirani opened this issue Apr 21, 2021 · 2 comments · Fixed by #72069
Assignees
@dimitris-athanasiou
Labels
:ml Machine learning Team:ML Meta label for the ML team >test-failure Triaged test failures from CI

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Apr 21, 2021 •
edited
Loading

Build scan: https://gradle-enterprise.elastic.co/s/vptinxha2wxme

Repro line:

./gradlew ':x-pack:plugin:yamlRestTest' --tests "org.elasticsearch.xpack.test.rest.XPackRestIT.test {p0=ml/evaluate_data_frame/Test classification given missing actual_field}" \
  -Dtests.seed=96A8B5076DF8D87B \
  -Dtests.locale=it \
  -Dtests.timezone=America/Guatemala \
  -Druntime.java=8

Reproduces locally?: no

Applicable branches: 7.13, likely others

Failure history: only one failure of its type so far

Failure excerpt:

java.lang.AssertionError: Failure at [ml/evaluate_data_frame:189]: got unexpected warning header [
    	299 Elasticsearch-7.13.0-SNAPSHOT-45067c011e99363d974ebf96244bec212663eada "this request accesses system indices: [.ml-config], but in a future major version, direct access to system indices will be prevented by default"
    ]
        at __randomizedtesting.SeedInfo.seed([96A8B5076DF8D87B:1EFC8ADDC304B583]:0)
        at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:451)
@jtibshirani jtibshirani added >test-failure Triaged test failures from CI :ml Machine learning labels Apr 21, 2021
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Apr 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@jtibshirani
Copy link
Contributor Author

It looks like these deprecation warnings were added in #60945.

@dimitris-athanasiou dimitris-athanasiou self-assigned this Apr 22, 2021
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Apr 22, 2021
@dimitris-athanasiou
[ML] Avoid direct action on system index in evaluate REST tests
fed33d1 
Refreshing all indices seems to potentially touch on the `.ml-config`
index which is a system index. That can cause a depracation warning
for directly accessing system indices. This commit changes the
refresh request to just be on the data index the test uses.

Closes elastic#72046
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Apr 22, 2021
Merged
dimitris-athanasiou added a commit that referenced this issue Apr 22, 2021
@dimitris-athanasiou
[ML] Avoid direct action on system index in evaluate REST tests (#72069)
af1aa5d 
Refreshing all indices seems to potentially touch on the `.ml-config`
index which is a system index. That can cause a depracation warning
for directly accessing system indices. This commit changes the
refresh request to just be on the data index the test uses.

Closes #72046
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Apr 22, 2021
Merged
dimitris-athanasiou added a commit that referenced this issue Apr 22, 2021
@dimitris-athanasiou
[7.x][ML] Avoid direct action on system index in evaluate REST tests (#…
4ed85fe 
…72069) (#72074)

Refreshing all indices seems to potentially touch on the `.ml-config`
index which is a system index. That can cause a depracation warning
for directly accessing system indices. This commit changes the
refresh request to just be on the data index the test uses.

Closes #72046

Backport of #72069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitris-athanasiou dimitris-athanasiou

Labels
:ml Machine learning Team:ML Meta label for the ML team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Avoid direct action on system index in evaluate REST tests dimitris-athanasiou/elasticsearch
3 participants
@jtibshirani @dimitris-athanasiou @elasticmachine