-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude synthetic source test for TSDB from mixedClusterTests #100592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java # server/src/test/java/org/elasticsearch/index/mapper/SourceFieldMapperTests.java # server/src/test/java/org/elasticsearch/index/query/SearchExecutionContextTests.java
kkrik-es
added
>test
Issues or PRs that are addressing/adding tests
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
:StorageEngine/TSDB
You know, for Metrics
labels
Oct 10, 2023
Pinging @elastic/es-analytics-geo (Team:Analytics) |
martijnvg
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but let's run full bwc tests before merging?
kkrik-es
changed the title
Don't print synthetic source in mapping for bwc tests (part 2)
Exclude synthetic source test for TSDB from mixedClusterTests
Oct 11, 2023
martijnvg
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:StorageEngine/TSDB
You know, for Metrics
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
>test
Issues or PRs that are addressing/adding tests
test-full-bwc
Trigger full BWC version matrix tests
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We suspect the synthetic source test for tsdb mappings that was added in #98808 may be contributing to flakiness in mixed cluster tests.
This change also reverts #100572 since it doesn't work as expected - see comment below.
Fixes #100562