Skip to content

Fix generation of synthetic source test data for range mapper to be deterministic #113304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lkts merged 2 commits into from
Sep 23, 2024
Merged

Fix generation of synthetic source test data for range mapper to be deterministic #113304

lkts merged 2 commits into from
Sep 23, 2024

Conversation

@lkts
Copy link
Contributor

@lkts lkts commented Sep 20, 2024 •
edited
Loading

Tests write a TestRange instance to XContentBuilder multiple times and very reasonably expect the same result. However due to a randomBoolean in conversion code this was not the case.

Closes #113217.
Closes #113220.
Closes #113234.

@lkts lkts requested a review from kkrik-es September 20, 2024 18:45
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Sep 20, 2024
@lkts lkts added >test Issues or PRs that are addressing/adding tests auto-backport-and-merge :StorageEngine/Mapping The storage related side of mappings v8.16.0 labels Sep 20, 2024
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 20, 2024

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 20, 2024
@lkts lkts requested review from dnhatn and limotova September 20, 2024 18:47
dnhatn
dnhatn approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @lkts

@lkts lkts mentioned this pull request Sep 23, 2024
Merged
@lkts lkts merged commit 02084d3 into elastic:main Sep 23, 2024
@lkts lkts deleted the fix_synthetic_source_tests_with_keep_arrays branch September 23, 2024 15:27
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 23, 2024

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 113304

lkts added a commit to lkts/elasticsearch that referenced this pull request Sep 23, 2024
@lkts
Fix generation of synthetic source test data for range mapper to be d…
d79a499 
…eterministic (elastic#113304)

(cherry picked from commit 02084d3)

# Conflicts:
#	muted-tests.yml
@lkts lkts mentioned this pull request Sep 23, 2024
Merged
@lkts
Copy link
Contributor Author

lkts commented Sep 23, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Questions ?

Please refer to the Backport tool documentation

lkts added a commit that referenced this pull request Sep 23, 2024
@lkts
Fix generation of synthetic source test data for range mapper to be d…
a443d47 
…eterministic (#113304) (#113402)

(cherry picked from commit 02084d3)

# Conflicts:
#	muted-tests.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

@kkrik-es kkrik-es kkrik-es approved these changes

@limotova limotova Awaiting requested review from limotova

Assignees

No one assigned

Labels

backport pending :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.16.0 v9.0.0

Projects

None yet

Milestone

No milestone

4 participants

@lkts @elasticsearchmachine @dnhatn @kkrik-es