Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes reading of CORS pre-flight headers and methods #17523

Closed
wants to merge 1 commit into from
Closed

Fixes reading of CORS pre-flight headers and methods #17523

wants to merge 1 commit into from

Conversation

abeyad
Copy link

@abeyad abeyad commented Apr 5, 2016

CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Fixes #17483

@abeyad abeyad added >bug review :Core/Infra/REST API REST infrastructure and utilities v5.0.0-alpha1 labels Apr 5, 2016
@abeyad abeyad force-pushed the bug/fix-cors-settings-reading branch from 9a23110 to 532d6ac Compare April 5, 2016 02:14
abeyad pushed a commit to abeyad/elasticsearch that referenced this pull request Apr 5, 2016
Fixes reading of CORS pre-flight headers and methods
7808572 
CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Backports elastic#17523
@abeyad abeyad mentioned this pull request Apr 5, 2016
Closed
abeyad pushed a commit to abeyad/elasticsearch that referenced this pull request Apr 5, 2016
Fixes reading of CORS pre-flight headers and methods
24599df 
CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Backports elastic#17523
This was referenced Apr 5, 2016
Closed
Closed
Fixes reading of CORS pre-flight headers and methods
4fbe1ad 
CORS headers and methods config parameters must be read as arrays.  This
commit fixes the issue.  It affects http.cors.allow-methods and
http.cors.allow-headers.

Fixes elastic#17483
@abeyad abeyad force-pushed the bug/fix-cors-settings-reading branch from 532d6ac to 4fbe1ad Compare April 5, 2016 13:34
@abeyad
Copy link
Author

abeyad commented Apr 5, 2016

@spinscale Do you have spare cycles to review?

@dakrone
Copy link
Member

dakrone commented Apr 7, 2016

this LGTM

abeyad pushed a commit that referenced this pull request Apr 7, 2016
Fixes reading of CORS pre-flight headers and methods
39253df 
CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Closes #17525
Backports #17523
abeyad pushed a commit that referenced this pull request Apr 7, 2016
Fixes reading of CORS pre-flight headers and methods
1ecc627 
CORS headers and methods config parameters must be read as arrays. This
commit fixes the issue. It affects http.cors.allow-methods and
http.cors.allow-headers.

Closes #17524
Backports #17523
@abeyad
Copy link
Author

abeyad commented Apr 7, 2016

Closed by Commit 763a659

@abeyad abeyad closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities v5.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with http.cors.allow-methods
2 participants
@abeyad @dakrone