_flush should block by default
#20597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default behavior of `_flush` to block if other flushes are ongoing. This also removes the use of `FlushNotAllowedException` and instead simply return immediately by skipping the flush. Users should be aware if they set this option that the flush might or might not flush everything to disk ie. no transactional behavior of some sort. Closes elastic#20569
Contributor
|
LGTM. Thx @s1monw ! |
Contributor
Author
|
FYI - I will open a sep issue for the migration guide since this goes in to master and we only need that entry on 5.x and 5.0 |
s1monw
added a commit
that referenced
this pull request
Sep 21, 2016
This commit changes the default behavior of `_flush` to block if other flushes are ongoing. This also removes the use of `FlushNotAllowedException` and instead simply return immediately by skipping the flush. Users should be aware if they set this option that the flush might or might not flush everything to disk ie. no transactional behavior of some sort. Closes #20569
s1monw
added a commit
that referenced
this pull request
Sep 21, 2016
This commit changes the default behavior of `_flush` to block if other flushes are ongoing. This also removes the use of `FlushNotAllowedException` and instead simply return immediately by skipping the flush. Users should be aware if they set this option that the flush might or might not flush everything to disk ie. no transactional behavior of some sort. Closes #20569
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Sep 21, 2016
This change adds a note to the migration guide for the change of the default value from `false` to `true`. Relates to elastic#20597
s1monw
added a commit
that referenced
this pull request
Sep 21, 2016
This change adds a note to the migration guide for the change of the default value from `false` to `true`. Relates to #20597
s1monw
added a commit
that referenced
this pull request
Sep 21, 2016
This change adds a note to the migration guide for the change of the default value from `false` to `true`. Relates to #20597
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this pull request
Sep 22, 2016
This is a issue in all 2.x releases that if we run into a FlushNotAllowedEngineException on a replica (ie. a flush is already running) we fail the replica. We should just ignore this excepiton and not fail the shard. Note: this is against 2.x only. Master changed in elastic#20597 Relates to elastic#20569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default behavior of
_flushto block if other flushes are ongoing.This also removes the use of
FlushNotAllowedExceptionand instead simply return immediatelyby skipping the flush. Users should be aware if they set this option that the flush might or might
not flush everything to disk ie. no transactional behavior of some sort.
Closes #20569