Skip to content

Conversation

@cbuescher
Copy link
Member

@cbuescher cbuescher commented May 31, 2017

This adds a basic unit test for the PathHierarchyTokenizerFactory and checks some analysis outputs.

@cbuescher cbuescher added :Search Relevance/Analysis How text is split into tokens review >test Issues or PRs that are addressing/adding tests v6.0.0 labels May 31, 2017
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed to be unused, so I removed it.

@cbuescher cbuescher force-pushed the add-PathHierarchyTokenizerFactoryTests branch 5 times, most recently from 5001ef2 to fbb4074 Compare June 1, 2017 17:06
@cbuescher cbuescher force-pushed the add-PathHierarchyTokenizerFactoryTests branch from fbb4074 to 23a99ac Compare June 8, 2017 10:01
@polyfractal
Copy link
Contributor

LGTM 👍

@cbuescher
Copy link
Member Author

@polyfractal thanks for the review

@cbuescher cbuescher merged commit d3442f7 into elastic:master Jun 15, 2017
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jun 16, 2017
…y-context

* 'master' of github.com:elastic/elasticsearch: (21 commits)
  [DOCS] Clarify expected availability of HDFS for the HDFS Repository (elastic#25220)
  Remove some redundant 140 character checkstyle suppressions
  [Docs] more fix for the parent-join docs
  [Docs] Fix cross reference for parent-join field
  More advices around search speed and disk usage. (elastic#25252)
  Add documentation for the new parent-join field (elastic#25227)
  [analysis-icu] Allow setting unicodeSetFilter (elastic#20814)
  Introduce translog size and age based retention policies (elastic#25147)
  Add needs methods for specific variables to Painless script context factories. (elastic#25267)
  Improves snapshot logging and snapshoth deletion error handling (elastic#25264)
  Add unit test for PathHierarchyTokenizerFactory (elastic#24984)
  Deprecate tribe service
  Moved more token filters to analysis-common module.
  [Test] Make sure that SearchAfterSortedDocQueryTests uses a single threaded searcher
  [DOCS] Defined es-test-dir and plugins-examples-dir in index.asciidoc.  (elastic#25232)
  Test fix - removed superfluous assertion (elastic#25247)
  [Test] restore BWC for parent-join now that the new mapping format is in 5.x
  Add a section named "relations" in the ParentJoinFieldMapper (elastic#25248)
  test: Ported more OldIndexBackwardsCompatibilityIT tests to full cluster restart qa tests. (elastic#25173)
  fix: Sort Processor does not have proper behavior with targetField (elastic#25237)
  ...
@cbuescher cbuescher deleted the add-PathHierarchyTokenizerFactoryTests branch November 27, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Analysis How text is split into tokens >test Issues or PRs that are addressing/adding tests v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants