Skip to content

Conversation

@karmi
Copy link
Contributor

@karmi karmi commented Oct 5, 2017

This test has been failing in th Ruby runner, since it assumed the headers feature,
but was not annotated accordingly.

This patch adds the skip clause with the headers feature.

@karmi karmi force-pushed the karmi/add_skip_headers_to_bulk_test branch from 6ff4611 to faf41b6 Compare October 5, 2017 16:42
karmi added a commit that referenced this pull request Oct 5, 2017
This test has been failing in th Ruby runner, since it assumed the `headers` feature,
but was not annotated accordingly.

This patch adds the `skip` clause with the `headers` feature.

Closes #26896
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @karmi

@karmi karmi added :Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests labels Oct 6, 2017
This test has been failing in th Ruby runner, since it assumed the `headers` feature,
but was not annotated accordingly.

This patch adds the `skip` clause with the `headers` feature.

Closes #26896
@karmi karmi force-pushed the karmi/add_skip_headers_to_bulk_test branch from faf41b6 to 392d6a4 Compare October 6, 2017 12:24
@karmi karmi merged commit 392d6a4 into master Oct 6, 2017
karmi added a commit that referenced this pull request Oct 6, 2017
This test has been failing in th Ruby runner, since it assumed the `headers` feature,
but was not annotated accordingly.

This patch adds the `skip` clause with the `headers` feature.

Closes #26896
karmi added a commit that referenced this pull request Oct 6, 2017
This test has been failing in th Ruby runner, since it assumed the `headers` feature,
but was not annotated accordingly.

This patch adds the `skip` clause with the `headers` feature.

Closes #26896
@karmi
Copy link
Contributor Author

karmi commented Oct 8, 2017

Merged into 5.6, 6.0 and 6.x branches.

@karmi karmi deleted the karmi/add_skip_headers_to_bulk_test branch October 8, 2017 12:16
@javanna javanna added v5.6.3 and removed v5.6.4 labels Oct 9, 2017
@lcawl lcawl added v6.0.0-rc2 and removed v6.0.0 labels Oct 30, 2017
karmi added a commit that referenced this pull request Nov 12, 2017
This test has been failing in th Ruby runner, since it assumed the `headers` feature,
but was not annotated accordingly.

This patch adds the `skip` clause with the `headers` feature.

Closes #26896
@karmi
Copy link
Contributor Author

karmi commented Nov 12, 2017

It seems like I either forgot to merge this patch into 6.0 -- I've cherry-picked the commit into it and pushed.

@karmi karmi mentioned this pull request Nov 13, 2017
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests v5.6.3 v6.0.0-rc2 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants