From ab6fabc7fc639c351f429cc8528d5e6086f7472e Mon Sep 17 00:00:00 2001 From: Nik Everett Date: Tue, 1 May 2018 09:53:52 -0400 Subject: [PATCH] Build: Log a warning if disabling reindex-from-old We disable the reindex-from-old tests if we're running on windows or in a directory that contains a space. This adds a warning to the logs when we do that so that you can tell that it happened. This will be nice to have when looking at CI and will be a hint to anyone developing locally. --- modules/reindex/build.gradle | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/reindex/build.gradle b/modules/reindex/build.gradle index c0289f7df7266..a153cc555c81d 100644 --- a/modules/reindex/build.gradle +++ b/modules/reindex/build.gradle @@ -83,9 +83,11 @@ dependencies { es090 'org.elasticsearch:elasticsearch:0.90.13@zip' } -if (Os.isFamily(Os.FAMILY_WINDOWS) || rootProject.rootDir.toString().contains(" ")) { - // We can't get the pid files in windows and old versions of Elasticsearch doesn't set up the CLASSPATH correctly if there are spaces - // in the path. In either case, we skip reindex-from-old. +if (Os.isFamily(Os.FAMILY_WINDOWS)) { + logger.warn("Disabling reindex-from-old tests because we can't get the pid file on windows") + integTestRunner.systemProperty "tests.fromOld", "false" +} else if (rootProject.rootDir.toString().contains(" ")) { + logger.warn("Disabling reindex-from-old tests because Elasticsearch 1.7 won't start with spaces in the path") integTestRunner.systemProperty "tests.fromOld", "false" } else { integTestRunner.systemProperty "tests.fromOld", "true"