-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest: document fields that support templating #34536
Conversation
This change also updates many of the examples to use ecs as the example. Some additional minor improvements are also included. Part of elastic#33188
@@ -751,23 +751,23 @@ pipeline basis. Useful to find out which pipelines are used the most or spent th | |||
Appends one or more values to an existing array if the field already exists and it is an array. | |||
Converts a scalar to an array and appends one or more values to it if the field exists and it is a scalar. | |||
Creates an array containing the provided values if the field doesn't exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -846,7 +846,8 @@ Parses dates from fields, and then uses the date or timestamp as the timestamp f | |||
By default, the date processor adds the parsed date as a new field called `@timestamp`. You can specify a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1041,12 +1042,12 @@ understands this to mean `2016-04-01` as is explained in the <<date-math-index-n | |||
|====== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1365,21 +1366,22 @@ a scalar field to an object field. | |||
=== Fail Processor | |||
Raises an exception. This is useful for when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2077,14 +2079,14 @@ Converts a string to its lowercase equivalent. | |||
|
|||
[[remove-processor]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2115,23 +2117,24 @@ To remove multiple fields, you can use the following query: | |||
[[rename-processor]] | |||
=== Rename Processor | |||
Renames an existing field. If the field doesn't exist or the new name is already used, an exception will be thrown. | |||
Settings that support <<accessing-template-fields,template values>> are annotated with ^T^. | |||
|
|||
[[rename-options]] | |||
.Rename Options | |||
[options="header"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -2243,24 +2246,24 @@ and depending on the progress made, indexed into different indices. | |||
[[set-processor]] | |||
=== Set Processor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomcallahan @debadair ^^ example using description instead of superscript. Thoughts on which you prefer seeing side by side ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this the best of the available options
Pinging @elastic/es-core-infra |
@debadair - could I get your review on this documentation change ? I am abit uncertain about the superscript approach, however after playing around with a few options it came out as less busy/crowded as other options I tried. I have included screen shots of the rendered output to hopefully make the review quick. Also, I updated many of the examples to be based from https://github.com/elastic/ecs where applicable. |
So you're saying it didn't look good with "templating supported" as another column in the table? I am not a huge fan the superscript. It also appears that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably would have added "Supports template values." to the descriptions, rather than using the "T" annotation, but the annotation works, too. I would change "Settings" to "Options" to be consistent with the option tables, though.
@debadair @tomcallahan - Thanks for the feedback! I have removed the superscript in favor of a comment in the description. (and updated the screen shots) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this doc, we use the term template values
, however when I click through we refer to these as template snippets
, is there a reason we're not consistent here?
@tomcallahan - An oversight on my part, I will update the wording to be consistent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change also updates many of the examples to use ecs as the example. Some additional minor improvements are also included. Part of elastic#33188
This change also updates many of the examples to use ecs as the example. Some additional minor improvements are also included. Part of #33188
6.5 backport: e9a380c |
This change also updates many of the examples to use ecs as the example. Some additional minor improvements are also included. Part of #33188
This change also updates many of the examples to use ecs as the example.
Some additional minor improvements are also included.
Part of #33188