-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest: documentation for the drop processor #34570
Conversation
Pinging @elastic/es-core-infra |
@@ -1242,6 +1242,21 @@ Reference key modifier example | |||
* error = REFUSED | |||
|====== | |||
|
|||
[[drop-processor]] | |||
=== Drop Processor | |||
Drops the document without raising any an errors. This is useful to prevent the document from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo s/an//
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@original-brownbear - thanks! fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakelandis thanks LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, just one ask.
-------------------------------------------------- | ||
{ | ||
"drop": { | ||
"if" : "ctx.tags.contains('production') != true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to show an equality check, can it be with a string value? contains already returns a boolean, so there is no need to check equality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjernst good call! i updated the example for simple string example (that can't throw a NPE). Tangentially, I am working on more comprehensive documentation around the conditional.
6.5 backport: aed947f |
part of #33188