[Tests] Change cluster scope in CorruptedFileIT and FlushIT #37229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test-failure
Collaborator
|
Pinging @elastic/es-distributed |
tlrx
force-pushed
the
change-cluster-scope
branch
from
fa5199a to
b5ef14b
Compare
Member
Author
|
@elasticmachine run gradle build tests 2 |
1 similar comment
Member
Author
|
@elasticmachine run gradle build tests 2 |
tlrx
added a commit
that referenced
this pull request
Jan 9, 2019
These tests failed on CI multiple times in the past weeks because they use a test cluster with a SUITE scope that recreates nodes between tests. With such a scope, nodes can be recreated in between test executions and can inherit a node id from a previous test execution, while they are assigned a random data path. With the successive node recreations it is possible that a newly recreated node shares the same node id (but different data path) as a non recreated node. This commit changes the cluster scope of the CorruptedFileIT and FlushIT tests which often fail. The failure is reproducable with : ./gradlew :server:integTest -Dtests.seed=EF3A50C225CF377 -Dtests.class=org.elasticsearch.index.store.CorruptedFileIT -Dtests.security.manager=true -Dtests.locale=th-TH-u-nu-thai-x-lvariant-TH -Dtests.timezone=America/Rio_Branco -Dcompiler.java=11 -Druntime.java=8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests failed on CI multiple times in the past weeks because they use a test cluster with a
SUITEscope that recreates nodes between tests. With such a scope, nodes can be recreated in between test executions and can inherit a node id from a previous test execution, while they are assigned a random data path. With the successive node recreations it is possible that a newly recreated node shares the same node id (but different data path) as a non recreated node.This commit changes the cluster scope of the CorruptedFileIT and FlushIT tests which often fail.
The failure is reproducable with :
It does not fix the underlying issue of data paths begin randomly assigned by InternalTestCluster.