Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Backport of types removal for Put/Get index templates (#38022)" #38427

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Revert "Backport of types removal for Put/Get index templates (#38022)" #38427

merged 1 commit into from
Feb 5, 2019

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Feb 5, 2019

Reverting #37484 as it breaks BWC tests on master.

@alpar-t alpar-t added the >test-mute Use for PR that only mute tests label Feb 5, 2019
original-brownbear
original-brownbear approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming you can get it to pass locally)

@alpar-t alpar-t merged commit 5e9688b into elastic:6.x Feb 5, 2019
@alpar-t alpar-t deleted the revert-deprecate-types-put-get-index branch February 5, 2019 15:01
@alpar-t alpar-t mentioned this pull request Feb 5, 2019
Merged
@jkakavas jkakavas mentioned this pull request Feb 5, 2019
Merged
@cbuescher cbuescher mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

@markharwood markharwood Awaiting requested review from markharwood

Assignees
No one assigned
Labels
>test-mute Use for PR that only mute tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpar-t @original-brownbear