diff --git a/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java b/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java index 11c8d356bf2e2..8fcc113ca952f 100644 --- a/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java +++ b/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java @@ -150,7 +150,7 @@ public IngestDocument execute(IngestDocument ingestDocument) { } } } else { - // Deprecated format, removed in 7.0 + // Deprecated format, removed in 8.0 for (Property property : this.properties) { switch (property) { case NAME: @@ -316,7 +316,7 @@ public UserAgentProcessor create(Map factories, Strin if (useECS == false) { deprecationLogger.deprecated("setting [ecs] to false for non-common schema " + - "format is deprecated and will be removed in 7.0, set to true to use the non-deprecated format"); + "format is deprecated and will be removed in 8.0, set to true to use the non-deprecated format"); } return new UserAgentProcessor(processorTag, field, targetField, parser, properties, ignoreMissing, useECS); @@ -326,12 +326,12 @@ public UserAgentProcessor create(Map factories, Strin enum Property { NAME, - // Deprecated in 6.7 (superceded by VERSION), to be removed in 7.0 + // Deprecated in 6.7 (superceded by VERSION), to be removed in 8.0 @Deprecated MAJOR, @Deprecated MINOR, @Deprecated PATCH, OS, - // Deprecated in 6.7 (superceded by just using OS), to be removed in 7.0 + // Deprecated in 6.7 (superceded by just using OS), to be removed in 8.0 @Deprecated OS_NAME, @Deprecated OS_MAJOR, @Deprecated OS_MINOR, diff --git a/modules/ingest-user-agent/src/test/resources/rest-api-spec/test/ingest-useragent/20_useragent_processor.yml b/modules/ingest-user-agent/src/test/resources/rest-api-spec/test/ingest-useragent/20_useragent_processor.yml index c5539a8ccc6d4..718ba0cea02fd 100644 --- a/modules/ingest-user-agent/src/test/resources/rest-api-spec/test/ingest-useragent/20_useragent_processor.yml +++ b/modules/ingest-user-agent/src/test/resources/rest-api-spec/test/ingest-useragent/20_useragent_processor.yml @@ -90,7 +90,7 @@ - do: warnings: - - "setting [ecs] to false for non-common schema format is deprecated and will be removed in 7.0, set to true to use the non-deprecated format" + - "setting [ecs] to false for non-common schema format is deprecated and will be removed in 8.0, set to true to use the non-deprecated format" - "the [os_major] property is deprecated for the user-agent processor" ingest.put_pipeline: id: "my_pipeline" diff --git a/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecks.java b/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecks.java index 8142622b1f0ba..dd2f5ad53f529 100644 --- a/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecks.java +++ b/x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecks.java @@ -8,7 +8,6 @@ import org.elasticsearch.cluster.ClusterState; import org.elasticsearch.cluster.metadata.MetaData; -import org.elasticsearch.ingest.ConfigurationUtils; import org.elasticsearch.ingest.IngestService; import org.elasticsearch.ingest.PipelineConfiguration; import org.elasticsearch.xpack.core.deprecation.DeprecationIssue; @@ -78,8 +77,7 @@ static DeprecationIssue checkUserAgentPipelines(ClusterState state) { .filter(Objects::nonNull) .filter(processor -> processor.containsKey("user_agent")) .map(processor -> processor.get("user_agent")) - .anyMatch(processorConfig -> - false == ConfigurationUtils.readBooleanProperty(null, null, processorConfig, "ecs", false)); + .anyMatch(processorConfig -> processorConfig.containsKey("ecs") == false); }) .map(PipelineConfiguration::getId) .sorted() // Make the warning consistent for testing purposes @@ -89,7 +87,7 @@ static DeprecationIssue checkUserAgentPipelines(ClusterState state) { "User-Agent ingest plugin will use ECS-formatted output", "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" + "#ingest-user-agent-ecs-always", - "Ingest pipelines " + pipelinesWithDeprecatedEcsConfig + " will change to using ECS output format in 7.0"); + "Ingest pipelines " + pipelinesWithDeprecatedEcsConfig + " will change to using ECS output format by default in 7.0"); } return null; diff --git a/x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecksTests.java b/x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecksTests.java index 007c3edd0a85e..53d541725afb2 100644 --- a/x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecksTests.java +++ b/x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/ClusterDeprecationChecksTests.java @@ -157,7 +157,7 @@ public void testUserAgentEcsCheck() { "User-Agent ingest plugin will use ECS-formatted output", "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-7.0.html" + "#ingest-user-agent-ecs-always", - "Ingest pipelines [ecs_false, ecs_null] will change to using ECS output format in 7.0"); + "Ingest pipelines [ecs_null] will change to using ECS output format by default in 7.0"); assertEquals(singletonList(expected), issues); } }