Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old assertion in resync replication request #42390

Merged
merged 2 commits into from
May 23, 2019

Conversation

jasontedor
Copy link
Member

This assertion was left behind from a previous cleanup. The assertion was there to remove some stale logic not needed when master would not talk to 6.x anymore. When that logic was removed, this assertion was left behind. This commit removes that stale assertion.

Relates #38556
Relates #39883

This assertion was left behind from a previous cleanup. The assertion
was there to remove some stale logic not needed when master would not
talk to 6.x anymore. When that logic was removed, this assertion was
left behind. This commit removes that stale assertion.
@jasontedor jasontedor added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 labels May 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…sertion

* elastic/master:
  Make packer cache branches explicit (elastic#41990)
  Re-mute all ml_datafeed_crud rolling upgrade tests
  Ensure testAckedIndexing uses disruption index settings
  add 7_3 as version (elastic#42368)
  Fix grammar problem in stemming reference. (elastic#42148)
@jasontedor jasontedor merged commit 2721326 into elastic:master May 23, 2019
@jasontedor jasontedor deleted the remove-leftover-assertion branch May 23, 2019 12:15
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This assertion was left behind from a previous cleanup. The assertion
was there to remove some stale logic not needed when master would not
talk to 6.x anymore. When that logic was removed, this assertion was
left behind. This commit removes that stale assertion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >non-issue v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants