Upgrade jcodings dependency to 1.0.44 #43334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyfractal
added
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
martijnvg
approved these changes
Jun 23, 2019
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM
Sorry, this one fell off my radar.
spinscale
added a commit
that referenced
this pull request
Jun 26, 2019
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 7, 2019
This reverts commit 08a3549 and adds a test that demonstrates that grok with ignore case fails with the new dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12, also requiring an upgrade of joni).
henningandersen
added a commit
that referenced
this pull request
Nov 7, 2019
This reverts commit 08a3549 and adds a test that demonstrates that grok with ignore case fails with the new dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12, also requiring an upgrade of joni). This would crash ES with a `NoSuchFieldErrror` when using case insensitive matching.
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Nov 7, 2019
Added test demonstrating that grok using ignore case works, since this does a minimal test that the `joni` and `jcodings` libraries are compatible. Forward-port of test from elastic#43334
henningandersen
added a commit
that referenced
this pull request
Nov 7, 2019
Added test demonstrating that grok using ignore case works, since this does a minimal test that the `joni` and `jcodings` libraries are compatible. Forward-port of test from #43334
henningandersen
added a commit
that referenced
this pull request
Nov 7, 2019
Added test demonstrating that grok using ignore case works, since this does a minimal test that the `joni` and `jcodings` libraries are compatible. Forward-port of test from #43334
henningandersen
added a commit
that referenced
this pull request
Nov 7, 2019
Added test demonstrating that grok using ignore case works, since this does a minimal test that the `joni` and `jcodings` libraries are compatible. Forward-port of test from #43334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers note: I intent to backport this into master/7.x, please object as part of the review, if you disagree.
I will also update the joni dependency in another PR, but would like to make sure, this passes first.