Implement AvgAggregatorTests#testDontCacheScripts and remove AvgIT #45737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csoulios
added
>test
Collaborator
|
Pinging @elastic/es-analytics-geo |
polyfractal
approved these changes
Aug 20, 2019
Contributor
polyfractal
left a comment
polyfractal
left a comment
There was a problem hiding this comment.
LGTM. Hooray for removing an integration test 🎉
csoulios
added a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 20, 2019
… tests (elastic#45737) Similar to PR elastic#45030 integration test testDontCacheScripts() was moved to unit test AvgAggregatorTests#testDontCacheScripts. AvgIT class was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to PR #45030 integration test
testDontCacheScripts()was moved to unit test AvgAggregatorTests#testDontCacheScripts.AvgIT class was removed.