Wait for elasticsearch exit in packaging tests #47242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archives stopElasticsearch utility method sends SIGTERM to the elasticsearch process, but does not wait for it to exit. That can cause subsequent tests to sometimes file. This commit adds wait logic to both linux and windows for the stopElasticsearch method. closes elastic#44501
rjernst
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
alpar-t
approved these changes
Sep 30, 2019
alpar-t
pushed a commit
that referenced
this pull request
Sep 30, 2019
The archives stopElasticsearch utility method sends SIGTERM to the elasticsearch process, but does not wait for it to exit. That can cause subsequent tests to sometimes file. This commit adds wait logic to both linux and windows for the stopElasticsearch method. closes #44501
alpar-t
pushed a commit
that referenced
this pull request
Sep 30, 2019
The archives stopElasticsearch utility method sends SIGTERM to the elasticsearch process, but does not wait for it to exit. That can cause subsequent tests to sometimes file. This commit adds wait logic to both linux and windows for the stopElasticsearch method. closes #44501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archives stopElasticsearch utility method sends SIGTERM to the
elasticsearch process, but does not wait for it to exit. That can cause
subsequent tests to sometimes file. This commit adds wait logic to both
linux and windows for the stopElasticsearch method.
closes #44501