-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripting: get context names REST API #48026
Scripting: get context names REST API #48026
Conversation
Adds `GET /_script_context`, returning a `contexts` object with each available context as a key whose value is an empty object. eg. ``` { "contexts": { "aggregation_selector": {}, "aggs": {}, "aggs_combine": {}, ... } } ``` refs: elastic#47411
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I have a few comments.
...main/java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponse.java
Outdated
Show resolved
Hide resolved
...java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponseTests.java
Show resolved
Hide resolved
...main/java/org/elasticsearch/action/admin/cluster/storedscripts/GetScriptContextResponse.java
Outdated
Show resolved
Hide resolved
...va/org/elasticsearch/action/admin/cluster/storedscripts/TransportGetScriptContextAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/client/ClusterAdminClient.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/script/ScriptService.java
Outdated
Show resolved
Hide resolved
…ode, do not use master action, use set for getContextNames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine run elasticsearch-ci/packaging-sample |
…e/47411-painless-script-context-rest_1_name
Adds `GET /_script_context`, returning a `contexts` object with each available context as a key whose value is an empty object. eg. ``` { "contexts": { "aggregation_selector": {}, "aggs": {}, "aggs_combine": {}, ... } } ``` refs: elastic#47411
Adds `GET /_script_context`, returning a `contexts` object with each available context as a key whose value is an empty object. eg. ``` { "contexts": { "aggregation_selector": {}, "aggs": {}, "aggs_combine": {}, ... } } ``` refs: #47411
@stu-elastic Please remember to label all PRs with change type, area and version labels. This is important for the release notes process as well as letting people looking at the PR know quickly where it is targetting |
I've added some labels I think are appropriate but please check and amend as necessary |
Scripting: get context names REST API
Adds
GET /_script_context
, returning acontexts
object with eachavailable context as a key whose value is an empty object. eg.
refs: #47411