Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redundant Version Param from Repository APIs #48231

Merged

Conversation

original-brownbear
Copy link
Member

This parameter isn't used by any implementation

This parameter isn't used by any implementation
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear original-brownbear changed the title Remove Version from Repository#IndexShardSnapshotStatus Remove Redundant Version Param from Repository APIs Oct 18, 2019
@original-brownbear
Copy link
Member Author

Jenkins test this

2 similar comments
@original-brownbear
Copy link
Member Author

Jenkins test this

@original-brownbear
Copy link
Member Author

Jenkins test this

@original-brownbear
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin

@original-brownbear
Copy link
Member Author

Thanks Tanguy!

@original-brownbear original-brownbear merged commit 6563c0f into elastic:master Oct 21, 2019
@original-brownbear original-brownbear deleted the drop-redundant-version branch October 21, 2019 13:05
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 21, 2019
This parameter isn't used by any implementation
original-brownbear added a commit that referenced this pull request Oct 21, 2019
This parameter isn't used by any implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants