Remove unnecessary details logged for OIDC #48271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary details logged for OIDC.
bizybot
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security (:Security/Authentication) |
jkakavas
requested changes
Oct 22, 2019
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
added 2 commits
October 24, 2019 08:46
- truncate the string keeping first and last 2 chars. - the `OIDCTokenResponse` did not parse the error scenario correctly. - checks for the response status and then on error prints the response message as warning
jkakavas
reviewed
Oct 24, 2019
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Oct 24, 2019
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Oct 24, 2019
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Oct 24, 2019
...ty/src/main/java/org/elasticsearch/xpack/security/authc/oidc/OpenIdConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/1 |
…ecurity/authc/oidc/OpenIdConnectAuthenticator.java Co-Authored-By: Ioannis Kakavas <ikakavas@protonmail.com>
Note that we are not dealing with any and all kinds of JWTs here. This is specifically concerning the OpenID Connect specification and OpenID Connect's ID Tokens, that are not used for authentication. |
|
I'll defer to @jkakavas on this one. |
|
Hi @jkakavas, I have addressed your review comments, Could you please take a look when you get some time? Thank you for your time. |
|
@jkakavas Can you run with this one. |
|
Superseded by #48746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unnecessary details logged for OIDC.