Revert "Upgrade jcodings dependency to 1.0.44 (#43334)" #48899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08a3549 and adds a test that demonstrates that grok with ignore case fails with the new dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12, also requiring an upgrade of joni).
henningandersen
added
>bug
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
spinscale
approved these changes
Nov 7, 2019
Contributor
spinscale
left a comment
spinscale
left a comment
There was a problem hiding this comment.
Thx for catching that one.
LGTM once CI passes
Contributor
Author
|
Notice that this was already fixed by #47374 when this change in 7.4 was done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 08a3549 and adds a
test that demonstrates that grok with ignore case fails with the new
dependency (jcodings 1.0.44 has a breaking change compared to 1.0.12,
also requiring an upgrade of joni).
This would crash ES with a
NoSuchFieldErrrorwhen using case insensitive matching.I will forward port the test to 7.5, 7.x and master after merge.