[Transform] add debug log for configuration index #49484
Conversation
|
Pinging @elastic/ml-core (:ml/Transform) |
| @@ -327,6 +329,7 @@ public void getTransformConfigurationForUpdate( | |||
| // use sort to get the last | |||
| .addSort("_index", SortOrder.DESC) | |||
| .setSize(1) | |||
| .setAllowPartialSearchResults(false) | |||
There was a problem hiding this comment.
What does it mean "partial search results"? Results from a subset of nodes?
There was a problem hiding this comment.
It means that it will throw if a subset of the shards fail the search.
If true, the search will return as normal but indicate shard failures.
There was a problem hiding this comment.
subset of shards, which might be on different nodes, yes. In the default setting ES returns with 200 but actually might not have all results. This is somewhat "search engine behavior", if you care about consistency you can either ask for getFailedShards() in the response object or you disallow partial results which will make it throw. I prefer the more explicit behavior.
Note that per default the number of shards is 1 for this config index, therefore it should not make a difference in this case, because it should throw if all shards == 1 shard failed. But I think it's a good setting as the default might change.
There was a problem hiding this comment.
Ok, thanks for explanations.
hendrikmuhs
force-pushed
the
transform-put-more-debug
branch
from
7c519fc to
f7e559b
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
add debug log for transform creation and disallow partial results for retrieval
add debug log for transform creation and disallow partial results for retrieval