Make BlobStoreRepository#writeIndexGen API Async #49584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preliminary to shorten the diff of elastic#49060. In elastic#49060 we execute cluster state updates during the writing of a new index gen and thus it must be an async API.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
| @@ -1432,7 +1444,7 @@ public void verify(String seed, DiscoveryNode localNode) { | |||
| public String toString() { | |||
| return "BlobStoreRepository[" + | |||
| "[" + metadata.name() + | |||
| "], [" + blobStore() + ']' + | |||
| "], [" + blobStore.get() + ']' + | |||
There was a problem hiding this comment.
Not related to the other changes, but this one was weird as it created a side effect (lazy initializing the blobStore) in the toString and I added that fix here.
| writeIndexGen(updatedRepoData, repositoryStateId, true); | ||
| writeUpdatedRepoDataStep.onResponse(updatedRepoData); | ||
| }, listener::onFailure); | ||
| final ShardGenerations.Builder builder = ShardGenerations.builder(); |
There was a problem hiding this comment.
Formatting was just off here (double indent) before and I fixed it in this one.
|
Thanks Nhat! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 26, 2019
Preliminary to shorten the diff of elastic#49060. In elastic#49060 we execute cluster state updates during the writing of a new index gen and thus it must be an async API.
original-brownbear
added a commit
that referenced
this pull request
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary to shorten the diff of #49060. In #49060
we execute cluster state updates during the writing of a new
index gen and thus it must be an async API.
NOTE: This change should not have any functional impact whatsoever, it's just a simple API change to shorten the diff of #49060