-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add optional source filtering during data frame reindexing #49690
[ML] Add optional source filtering during data frame reindexing #49690
Conversation
Pinging @elastic/ml-core (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective. I left two comments.
Thanks for the documentation effort!
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from some typos in the docs
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/ml/df-analytics/apis/dfanalyticsresources.asciidoc
Outdated
Show resolved
Hide resolved
By the way, I hadn't seen István's review when I was doing mine. |
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsSource.java
Show resolved
Hide resolved
...n/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsSource.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/xpack/ml/dataframe/extractor/ExtractedFieldsDetectorTests.java
Outdated
Show resolved
Hide resolved
fa5f926
to
0866358
Compare
This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531
Co-Authored-By: István Zoltán Szabó <istvan.szabo@elastic.co>
Co-Authored-By: István Zoltán Szabó <istvan.szabo@elastic.co>
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Until #49690 is backported to 7.x
…lastic#49690) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531 Backport of elastic#49690
…49690) (#49718) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes #49531 Backport of #49690
…tic#49690) This adds a `_source` setting under the `source` setting of a data frame analytics config. The new `_source` is reusing the structure of a `FetchSourceContext` like `analyzed_fields` does. Specifying includes and excludes for source allows selecting which fields will get reindexed and will be available in the destination index. Closes elastic#49531
Until elastic#49690 is backported to 7.x
This adds a
_source
setting under thesource
setting of a dataframe analytics config. The new
_source
is reusing the structureof a
FetchSourceContext
likeanalyzed_fields
does. Specifyingincludes and excludes for source allows selecting which fields
will get reindexed and will be available in the destination index.
Closes #49531