Account trimAboveSeqNo in committed translog generation #50205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
ywelsch
suggested changes
Dec 16, 2019
| final long maxSeqNo = reader.getCheckpoint().maxSeqNo; | ||
| return maxSeqNo == SequenceNumbers.UNASSIGNED_SEQ_NO || maxSeqNo >= minSeqNo; | ||
| }); | ||
| .filter(reader -> minSeqNo <= SequenceNumbers.min(reader.getCheckpoint().trimmedAboveSeqNo, reader.getCheckpoint().maxSeqNo)); |
There was a problem hiding this comment.
I think we need to account for the case where trimmedAboveSeqNo is equal to SequenceNumbers.UNASSIGNED_SEQ_NO. Perhaps we can add a method to checkpoint called getMaxEffectiveSeqNo which is:
if (trimmedAboveSeqNo == SequenceNumbers.UNASSIGNED_SEQ_NO)
return maxSeqNo;
else
return Math.min(maxSeqNo, trimmedAboveSeqNo);
There was a problem hiding this comment.
SequenceNumbers.min should handle this case:
But having an explicit method is better. I pushed 563545c.
There was a problem hiding this comment.
Ah lol, I did not see that a special min method was used (I read it as Math.min).
|
Thanks Yannick. |
dnhatn
added a commit
that referenced
this pull request
Dec 16, 2019
Today we do not consider trimAboveSeqNo when calculating the translog generation of an index commit. If there is no new indexing after the primary promotion, then we won't be able to clean up the translog.
dnhatn
added a commit
that referenced
this pull request
Dec 16, 2019
Today we do not consider trimAboveSeqNo when calculating the translog generation of an index commit. If there is no new indexing after the primary promotion, then we won't be able to clean up the translog.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Today we do not consider trimAboveSeqNo when calculating the translog generation of an index commit. If there is no new indexing after the primary promotion, then we won't be able to clean up the translog.
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the fix for #49970, I found that we do not consider trimAboveSeqNo when calculating the translog generation of an index commit. If there is no new indexing after the primary promotion, then we won't be able to clean up the translog.