-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add num_top_feature_importance_values param to regression and classi… #50914
Merged
dimitris-athanasiou
merged 4 commits into
elastic:master
from
dimitris-athanasiou:add-top-feature-importance-values-param
Jan 14, 2020
Merged
[ML] Add num_top_feature_importance_values param to regression and classi… #50914
dimitris-athanasiou
merged 4 commits into
elastic:master
from
dimitris-athanasiou:add-top-feature-importance-values-param
Jan 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
force-pushed
the
add-top-feature-importance-values-param
branch
from
January 13, 2020 14:43
bf1c8a8
to
d6c473f
Compare
szabosteve
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective!
Thanks for the effort!
benwtrent
approved these changes
Jan 13, 2020
…fication analyses Adds a new parameter to regression and classification that enables computation of importance for the top most important features. The computation of the importance is based on SHAP (SHapley Additive exPlanations) method.
dimitris-athanasiou
force-pushed
the
add-top-feature-importance-values-param
branch
from
January 14, 2020 12:18
d7619b9
to
1f255b1
Compare
dimitris-athanasiou
changed the title
[ML] Add top_feature_importance_values param to regression and classi…
[ML] Add num_top_feature_importance_values param to regression and classi…
Jan 14, 2020
dimitris-athanasiou
deleted the
add-top-feature-importance-values-param
branch
January 14, 2020 13:01
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jan 14, 2020
Until elastic#50914 is backported to 7.x
dimitris-athanasiou
added a commit
that referenced
this pull request
Jan 14, 2020
Until #50914 is backported to 7.x
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jan 14, 2020
…nd classi… (elastic#50914) Adds a new parameter to regression and classification that enables computation of importance for the top most important features. The computation of the importance is based on SHAP (SHapley Additive exPlanations) method. Backport of elastic#50914
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
Jan 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dimitris-athanasiou
added a commit
that referenced
this pull request
Jan 14, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…assi… (elastic#50914) Adds a new parameter to regression and classification that enables computation of importance for the top most important features. The computation of the importance is based on SHAP (SHapley Additive exPlanations) method.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Until elastic#50914 is backported to 7.x
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fication analyses
Adds a new parameter to
regression
andclassification
that enables computationof importance for the top most important features. The computation of the importance
is based on SHAP (SHapley Additive exPlanations) method.