Handle nested and aliased fields correctly when copying mapping. #50918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
fix_dep_var_of_type_alias_problem
branch
3 times, most recently
from
0bca009 to
498b765
Compare
benwtrent
approved these changes
Jan 13, 2020
...ck/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/DataFrameAnalyticsIndex.java
Show resolved
Hide resolved
przemekwitek
force-pushed
the
fix_dep_var_of_type_alias_problem
branch
from
5569ad8 to
c771f5c
Compare
przemekwitek
added a commit
that referenced
this pull request
Jan 14, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mapping of a dependent variable which is either nested (
outer.inner) or an alias is handled incorrectly.This PR fixes it as it always fetches the mapping of a concrete field (i.e. the field that alias is pointing to).
Also it allows nested dependent variables as it traverses the path using
extractValuemethod rather than simpleget.Relates #50787