-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky usage tracking test #51169
Merged
nik9000
merged 1 commit into
elastic:master
from
nik9000:fix_indx_featuresete_usage_tests
Jan 17, 2020
Merged
Fix flaky usage tracking test #51169
nik9000
merged 1 commit into
elastic:master
from
nik9000:fix_indx_featuresete_usage_tests
Jan 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added tracking of index feature usage in elastic#51031 but due to some copy and paste errors the test fails on some seeds. This fixes those errors.
nik9000
added
:Data Management/Stats
Statistics tracking and retrieval APIs
v7.7.0
labels
Jan 17, 2020
Pinging @elastic/es-core-features (:Core/Features/Stats) |
jaymode
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jpountz
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks @nik9000 !
@elasticmachine run elasticsearch-ci/2 |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 17, 2020
We added tracking of index feature usage in elastic#51031 but due to some copy and paste errors the test fails on some seeds. This fixes those errors.
nik9000
added a commit
that referenced
this pull request
Jan 17, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
We added tracking of index feature usage in elastic#51031 but due to some copy and paste errors the test fails on some seeds. This fixes those errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/Stats
Statistics tracking and retrieval APIs
>test
Issues or PRs that are addressing/adding tests
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added tracking of index feature usage in #51031 but due to some copy
and paste errors the test fails on some seeds. This fixes those errors.