Add additional assertions and missed docs for errors in GetAlias API #51850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
Collaborator
|
Pinging @elastic/es-docs (>docs) |
Contributor
|
@elasticmachine ok to test |
probakowski
changed the title
probakowski
approved these changes
Feb 7, 2020
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this @timoninmaxim! I've modified title slightly to show that we've added something more than just docs, hope you don't mind.
Contributor
|
@elasticmachine update branch |
Contributor
|
@timoninmaxim I see autoupdate doesn't work here, you'll have to merge latest master to fix test failures |
timoninmaxim
force-pushed
the
feature/get_alias_docs
branch
from
77268a5 to
5dd27c1
Compare
Contributor
Author
|
Hi @probakowski ! Is there anything more I should do to make the PR to be merged? |
Contributor
|
Sorry, it felt out of my radar. Merged it to master and will backport it to 7.7. Thank you again for working on this! |
probakowski
pushed a commit
to probakowski/elasticsearch
that referenced
this pull request
Feb 24, 2020
probakowski
added a commit
that referenced
this pull request
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31499
Add missed documentation for error handling of GetAlias API.