Use FieldMapper to create the low level term queries in CommonTermQuery #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| static { | ||
| assert Version.LUCENE_47.onOrAfter(Lucene.VERSION) : "Remove obsolet code after upgrade to lucene 4.8"; |
|
Nice! I left minor comments but other than that, +1 to push! |
|
let's push! |
clintongormley
added
v0.90.13
v1.0.3
v1.0.2
v1.1.2
>bug
v1.1.0
v2.0.0-beta1
:Query DSL
and removed
v1.0.3
v1.1.2
labels
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a patch to lucene to fix this upstream:
https://issues.apache.org/jira/browse/LUCENE-5478
Closes #5258